From 026f4f5639db65b4118b57e7912a0b7aa9b88205 Mon Sep 17 00:00:00 2001
From: Robert Alessi <alessi@robertalessi.net>
Date: Wed, 19 Feb 2020 08:30:26 +0100
Subject: last arg. of \DeclareNewWitness was not actually optional: fixed

---
 ekdosis.dtx | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/ekdosis.dtx b/ekdosis.dtx
index 05a1b00..fdd14f3 100644
--- a/ekdosis.dtx
+++ b/ekdosis.dtx
@@ -379,15 +379,9 @@ Running "make install" installs the files in the local TeX tree.
   /witness/msName/.new value = {},
   /witness/origDate/.new value = {}
 }
-\NewDocumentCommand{\DeclareNewWitness}{m m m o}{%
-  \IfNoValueTF{#4}
-  {\luadirect{ekdosis.newwitness(
-      \luastringN{#1},
-      \luastringN{#2},
-      \luastringN{#3}
-      )}}
-  {\bgroup
-    \options{/witness,#4}
+\NewDocumentCommand{\DeclareNewWitness}{m m m O{}}{%
+  \bgroup
+  \options{/witness,#4}
     \letoption{/witness/settlement}\settlement@value
     \letoption{/witness/repository}\repository@value
     \letoption{/witness/idno}\idno@value
@@ -401,10 +395,9 @@ Running "make install" installs the files in the local TeX tree.
       \luastringO{\repository@value},
       \luastringO{\idno@value},
       \luastringO{\msName@value},
-      \luastringO{\origDate@value}
-      )}
-    \egroup}
-}
+      \luastringO{\origDate@value})}
+    \egroup
+  }
 \@onlypreamble\DeclareNewWitness
 \NewDocumentCommand{\DeclareNewHand}{m m m +O{}}{
   \luadirect{ekdosis.newhand(\luastringN{#1},
-- 
cgit v1.2.3